Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

ci: run lint / unit tests / docs as GH actions #153

Merged
merged 5 commits into from
Jan 18, 2022
Merged

ci: run lint / unit tests / docs as GH actions #153

merged 5 commits into from
Jan 18, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jan 14, 2022

The GH action is based on googleapis/python-api-core#287

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 14, 2022
@product-auto-label product-auto-label bot added the api: accessapproval Issues related to the googleapis/python-access-approval API. label Jan 14, 2022
@parthea parthea force-pushed the ci-move-checks-to-github-actions branch 4 times, most recently from 3f5b71d to 7dd127a Compare January 14, 2022 18:10
@parthea parthea force-pushed the ci-move-checks-to-github-actions branch from 7dd127a to 0b08d16 Compare January 14, 2022 18:17
@parthea parthea changed the title For testing purposes. ci: run lint / unit tests / docs / blacken as GH actions Jan 14, 2022
tswast
tswast reviewed Jan 14, 2022
View reviewed changes
tswast
tswast reviewed Jan 14, 2022
View reviewed changes
@parthea parthea changed the title ci: run lint / unit tests / docs / blacken as GH actions ci: run lint / unit tests / docs as GH actions Jan 14, 2022
tswast
tswast reviewed Jan 14, 2022
View reviewed changes
Copy link

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM at first glance. Can do a full review once you're ready

@parthea parthea marked this pull request as ready for review January 17, 2022 17:11
@parthea parthea requested a review from a team as a code owner January 17, 2022 17:11
@parthea parthea added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 17, 2022
@parthea parthea merged commit 9652aa1 into main Jan 18, 2022
@parthea parthea deleted the ci-move-checks-to-github-actions branch January 18, 2022 22:47
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: accessapproval Issues related to the googleapis/python-access-approval API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @tswast