Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 15, 2025. It is now read-only.

fix(deps): allow protobuf 3.19.5 #154

Merged
merged 2 commits into from
Oct 10, 2022
Merged

fix(deps): allow protobuf 3.19.5 #154

merged 2 commits into from
Oct 10, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 7, 2022 •
edited
Loading

fix(deps): regenerate pb2 files with grpcio-tools 1.48.2

BEGIN_COMMIT_OVERRIDE
fix(deps): require protobuf >=3.19.5
END_COMMIT_OVERRIDE

@parthea parthea requested a review from a team as a code owner October 7, 2022 15:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. labels Oct 7, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 7, 2022
@parthea
Copy link
Contributor Author

parthea commented Oct 7, 2022

The build is failing because the test is using a pinned version of protobuf==3.19.5 and the version of google-cloud-asset used in the test requires protobuf>=3.20.2. We'll should try restarting the build after googleapis/python-asset#508 is merged.

@parthea parthea merged commit 09d0f03 into main Oct 10, 2022
@parthea parthea deleted the allow-protobuf-3-19-5 branch October 10, 2022 18:25
@release-please release-please bot mentioned this pull request Oct 10, 2022
Merged
@parthea parthea added the release-please:force-run To run release-please label Dec 15, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees

@parthea parthea

Labels
api: accesscontextmanager Issues related to the googleapis/python-access-context-manager API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @vchudnov-g