Thanks to visit codestin.com
Credit goes to github.com

Skip to content

use unittest.mock instead of mock #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pgajdos opened this issue May 12, 2022 · 2 comments · Fixed by #713
Closed

use unittest.mock instead of mock #377

pgajdos opened this issue May 12, 2022 · 2 comments · Fixed by #713
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@pgajdos
Copy link

pgajdos commented May 12, 2022

Rather a question, do you plan to migrate mock usage in tests to built-in unittest.mock instead?
@pgajdos
Copy link
Author

pgajdos commented May 12, 2022

The testsuite runs fine for me with Python 3.8, 3.9 and 3.10 with unittest.mock:
https://build.opensuse.org/package/show/home:pgajdos:python/python-google-api-core/
https://build.opensuse.org/package/live_build_log/home:pgajdos:python/python-google-api-core:test/openSUSE_Tumbleweed/x86_64

It seems to be just s/import mock/from unittest import mock/

Backtround:
https://trello.com/c/S6eADbii/64-remove-python-mock
https://fedoraproject.org/wiki/Changes/DeprecatePythonMock

@parthea
Copy link
Collaborator

parthea commented May 12, 2022

Hi @pgajdos,
Thanks for reporting this issue. PRs are welcome!

@parthea parthea added the type: cleanup An internal cleanup or hygiene concern. label May 12, 2022
@pgajdos pgajdos mentioned this issue May 16, 2022
Closed
4 tasks
s-t-e-v-e-n-k added a commit to s-t-e-v-e-n-k/python-api-core that referenced this issue Oct 2, 2024
@s-t-e-v-e-n-k
Switch to unittest.mock from mock
4db4bbf 
Now that the minimum supported version of Python is 3.7, we can stop
using the external mock requirement, and import it from unittest. I have
also attempted to keep imports ordered.

Fixes googleapis#377
@s-t-e-v-e-n-k s-t-e-v-e-n-k mentioned this issue Oct 2, 2024
Merged
4 tasks
s-t-e-v-e-n-k added a commit to s-t-e-v-e-n-k/python-api-core that referenced this issue Oct 2, 2024
@s-t-e-v-e-n-k
test: Switch to unittest.mock from mock
5f28e21 
Now that the minimum supported version of Python is 3.7, we can stop
using the external mock requirement, and import it from unittest. I have
also attempted to keep imports ordered.

Fixes googleapis#377
@parthea parthea closed this as completed in 8c53381 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
2 participants
@pgajdos @parthea