Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove reference to blacken in contrib #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: remove reference to blacken in contrib #168

wants to merge 1 commit into from

Conversation

noahdietz
Copy link
Contributor

Removes reference to the blacken nox session as it doesn't exist in the noxfile.py.

@noahdietz noahdietz requested a review from a team as a code owner April 7, 2021 19:08
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2021
plamut
plamut reviewed Apr 8, 2021
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(LGTM)

Thought - quite a few (most?) other libraries have the blacken session defined, would core also benefit if we added it to its noxfile?

@busunkim96
Copy link
Contributor

Yup it'd be nice to add black to this repo to. Opened #169 to track that.

@noahdietz
Copy link
Contributor Author

I will close this then :) I was also kind of surprised because there is even a history of using black in this repo per the changelog. 🤷🏻‍♂️

@noahdietz noahdietz closed this Apr 8, 2021
@noahdietz noahdietz deleted the contrib-remove-blacken branch April 8, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahdietz @busunkim96 @plamut