fix: remove trailing underscore in transcoding #489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
vchudnov-g
reviewed
Mar 7, 2023
vchudnov-g
approved these changes
Mar 8, 2023
…ub.com/googleapis/python-api-core into remove-trailing-underscore-transcoding
atulep
reviewed
Mar 13, 2023
|
Waiting for approval in go/python-transcoding-reserved-keywords |
BenRKarl
reviewed
Mar 14, 2023
BenRKarl
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490
Googlers see proposal go/python-transcoding-reserved-keywords
This PR fixes an error seen in googleapis/python-debugger-client#151 which happens when the gapic generator appends an underscore to a field name which is a python reserved keyword. As similar issue was reported in #227 and fixed in #228. Based on comment #227 (comment) it is not possible for fields to have trailing
_at the proto level (Creating a field like this generates an error from the protobuf runtime).See build log https://github.com/googleapis/python-debugger-client/actions/runs/4292539515/jobs/7479094983 which shows the failure when a request has body with
breakpoint_instead ofbreakpoint_.