Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: change the documentation for using 'six.moves.collections_abc.Mapping' instead of 'dict' in 'client_options.from_dict()' #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2020
Merged

docs: change the documentation for using 'six.moves.collections_abc.Mapping' instead of 'dict' in 'client_options.from_dict()' #53

merged 2 commits into from
Jun 23, 2020

Conversation

paul1319
Copy link
Contributor

@paul1319 paul1319 commented Jun 18, 2020 •
edited
Loading

Closes #14

@paul1319
docs: change the documentation for using 'six.moves.collections_abc.M…
5e46589 
…apping' instead of 'dict' in 'client_options.from_dict()'
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2020
@paul1319 paul1319 marked this pull request as ready for review June 18, 2020 12:06
@paul1319 paul1319 requested a review from busunkim96 June 18, 2020 13:43
@busunkim96 busunkim96 merged commit c890675 into master Jun 23, 2020
@tseaver tseaver deleted the issue_14 branch December 8, 2020 18:12
This was referenced May 30, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client_options.from_dict should accept other mapping types
3 participants
@paul1319 @busunkim96 @googlebot