-
Notifications
You must be signed in to change notification settings - Fork 89
feat: add support for asynchronous rest streaming #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
4df2120
duplicating file to base
ohmayr 26f52a5
restore original file
ohmayr 204920a
duplicate file to async
ohmayr 2014ef6
restore original file
ohmayr fdeb437
Merge branch 'dups' into add-support-for-async-rest-streaming
ohmayr 8014f47
duplicate test file for async
ohmayr e84f03a
restore test file
ohmayr 91f5c13
Merge branch 'dups' into add-support-for-async-rest-streaming
ohmayr 0c2ee5c
feat: add support for asynchronous rest streaming
ohmayr 75ae7d7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] db7cfb3
fix naming issue
ohmayr 9da0113
Merge branch 'add-support-for-async-rest-streaming' of github.com:goo…
ohmayr 87eeca3
fix import module name
ohmayr d6abddd
pull auth feature branch
ohmayr a6a648d
revert setup file
ohmayr 8d30b2d
address PR comments
ohmayr 0b51b09
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 7d8f1e1
run black
ohmayr d793069
address PR comments
ohmayr 5f48f72
Merge branch 'add-support-for-async-rest-streaming' of github.com:goo…
ohmayr 70d1cdb
update nox coverage
ohmayr ee3a5ac
address PR comments
ohmayr 5a6e488
fix nox session name in workflow
ohmayr f2180da
use https for remote repo
ohmayr bc811e5
add context manager methods
ohmayr fc74ae0
address PR comments
ohmayr 1603818
Merge branch 'main' into add-support-for-async-rest-streaming
ohmayr cee06ab
update auth error versions
ohmayr 380dedf
Merge branch 'main' into add-support-for-async-rest-streaming
ohmayr 750d4cb
update import error
ohmayr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
# Copyright 2024 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Helpers for server-side streaming in REST.""" | ||
|
||
from collections import deque | ||
import string | ||
from typing import Deque, Union | ||
import types | ||
|
||
import proto | ||
import google.protobuf.message | ||
from google.protobuf.json_format import Parse | ||
|
||
|
||
class BaseResponseIterator: | ||
"""Base Iterator over REST API responses. This class should not be used directly. | ||
Args: | ||
response_message_cls (Union[proto.Message, google.protobuf.message.Message]): A response | ||
class expected to be returned from an API. | ||
Raises: | ||
ValueError: If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
response_message_cls: Union[proto.Message, google.protobuf.message.Message], | ||
): | ||
self._response_message_cls = response_message_cls | ||
# Contains a list of JSON responses ready to be sent to user. | ||
self._ready_objs: Deque[str] = deque() | ||
# Current JSON response being built. | ||
self._obj = "" | ||
# Keeps track of the nesting level within a JSON object. | ||
self._level = 0 | ||
# Keeps track whether HTTP response is currently sending values | ||
# inside of a string value. | ||
self._in_string = False | ||
# Whether an escape symbol "\" was encountered. | ||
self._escape_next = False | ||
|
||
self._grab = types.MethodType(self._create_grab(), self) | ||
|
||
def _process_chunk(self, chunk: str): | ||
if self._level == 0: | ||
if chunk[0] != "[": | ||
raise ValueError( | ||
"Can only parse array of JSON objects, instead got %s" % chunk | ||
) | ||
for char in chunk: | ||
if char == "{": | ||
if self._level == 1: | ||
# Level 1 corresponds to the outermost JSON object | ||
# (i.e. the one we care about). | ||
self._obj = "" | ||
if not self._in_string: | ||
self._level += 1 | ||
self._obj += char | ||
elif char == "}": | ||
self._obj += char | ||
if not self._in_string: | ||
self._level -= 1 | ||
if not self._in_string and self._level == 1: | ||
self._ready_objs.append(self._obj) | ||
elif char == '"': | ||
# Helps to deal with an escaped quotes inside of a string. | ||
if not self._escape_next: | ||
self._in_string = not self._in_string | ||
self._obj += char | ||
elif char in string.whitespace: | ||
if self._in_string: | ||
self._obj += char | ||
elif char == "[": | ||
if self._level == 0: | ||
self._level += 1 | ||
else: | ||
self._obj += char | ||
elif char == "]": | ||
if self._level == 1: | ||
self._level -= 1 | ||
else: | ||
self._obj += char | ||
else: | ||
self._obj += char | ||
self._escape_next = not self._escape_next if char == "\\" else False | ||
|
||
def _create_grab(self): | ||
if issubclass(self._response_message_cls, proto.Message): | ||
|
||
def grab(this): | ||
return this._response_message_cls.from_json( | ||
this._ready_objs.popleft(), ignore_unknown_fields=True | ||
) | ||
|
||
return grab | ||
elif issubclass(self._response_message_cls, google.protobuf.message.Message): | ||
|
||
def grab(this): | ||
return Parse(this._ready_objs.popleft(), this._response_message_cls()) | ||
|
||
return grab | ||
else: | ||
raise ValueError( | ||
"Response message class must be a subclass of proto.Message or google.protobuf.message.Message." | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
# Copyright 2024 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Helpers for asynchronous server-side streaming in REST.""" | ||
|
||
from typing import Union | ||
|
||
import proto | ||
|
||
try: | ||
import google.auth.aio.transport | ||
except ImportError as e: # pragma: NO COVER | ||
raise ImportError( | ||
"google-auth>=2.35.0 is required to use asynchronous rest streaming." | ||
) from e | ||
|
||
import google.protobuf.message | ||
from google.api_core._rest_streaming_base import BaseResponseIterator | ||
|
||
|
||
class AsyncResponseIterator(BaseResponseIterator): | ||
"""Asynchronous Iterator over REST API responses. | ||
|
||
Args: | ||
response (google.auth.aio.transport.Response): An API response object. | ||
response_message_cls (Union[proto.Message, google.protobuf.message.Message]): A response | ||
class expected to be returned from an API. | ||
|
||
Raises: | ||
ValueError: | ||
- If `response_message_cls` is not a subclass of `proto.Message` or `google.protobuf.message.Message`. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
response: google.auth.aio.transport.Response, | ||
response_message_cls: Union[proto.Message, google.protobuf.message.Message], | ||
): | ||
self._response = response | ||
self._chunk_size = 1024 | ||
self._response_itr = self._response.content().__aiter__() | ||
super(AsyncResponseIterator, self).__init__( | ||
response_message_cls=response_message_cls | ||
) | ||
|
||
async def __aenter__(self): | ||
return self | ||
|
||
async def cancel(self): | ||
"""Cancel existing streaming operation.""" | ||
await self._response.close() | ||
|
||
async def __anext__(self): | ||
while not self._ready_objs: | ||
try: | ||
chunk = await self._response_itr.__anext__() | ||
chunk = chunk.decode("utf-8") | ||
self._process_chunk(chunk) | ||
except StopAsyncIteration as e: | ||
if self._level > 0: | ||
raise ValueError("i Unfinished stream: %s" % self._obj) | ||
raise e | ||
except ValueError as e: | ||
raise e | ||
return self._grab() | ||
|
||
def __aiter__(self): | ||
return self | ||
|
||
async def __aexit__(self, exc_type, exc, tb): | ||
"""Cancel existing async streaming operation.""" | ||
await self._response.close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,7 @@ | |
"unit", | ||
"unit_grpc_gcp", | ||
"unit_wo_grpc", | ||
"unit_with_auth_aio", | ||
"cover", | ||
"pytype", | ||
"mypy", | ||
|
@@ -109,7 +110,7 @@ def install_prerelease_dependencies(session, constraints_path): | |
session.install(*other_deps) | ||
|
||
|
||
def default(session, install_grpc=True, prerelease=False): | ||
def default(session, install_grpc=True, prerelease=False, install_auth_aio=False): | ||
"""Default unit test session. | ||
|
||
This is intended to be run **without** an interpreter set, so | ||
|
@@ -144,6 +145,11 @@ def default(session, install_grpc=True, prerelease=False): | |
f"{constraints_dir}/constraints-{session.python}.txt", | ||
) | ||
|
||
if install_auth_aio: | ||
session.install( | ||
"google-auth @ git+https://[email protected]/googleapis/google-auth-library-python@8833ad6f92c3300d6645355994c7db2356bd30ad" | ||
) | ||
|
||
# Print out package versions of dependencies | ||
session.run( | ||
"python", "-c", "import google.protobuf; print(google.protobuf.__version__)" | ||
|
@@ -229,6 +235,12 @@ def unit_wo_grpc(session): | |
default(session, install_grpc=False) | ||
|
||
|
||
@nox.session(python=PYTHON_VERSIONS) | ||
def unit_with_auth_aio(session): | ||
"""Run the unit test suite with google.auth.aio installed""" | ||
default(session, install_auth_aio=True) | ||
|
||
|
||
@nox.session(python=DEFAULT_PYTHON_VERSION) | ||
def lint_setup_py(session): | ||
"""Verify that setup.py is valid (including RST check).""" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.