fix: ensure AccessEntry equality and repr uses the correct entity_type
#2182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
commented
May 13, 2025
There was a problem hiding this comment.
FYI: I did a mini-TDD for this. Both of these tests fail without the changes in dataset.py.
chelsea-lin
reviewed
May 13, 2025
| @@ -746,6 +755,13 @@ def test_dataset_property_with_condition(self, condition_1): | |||
| assert "dataset" in entry._properties | |||
| assert "condition" in entry._properties | |||
|
|
|||
| def test_repr_from_api_repr(self): | |||
There was a problem hiding this comment.
Can you please check the array of AccessEntry works too? The g3 failed tests show the None entity type in the array: https://screenshot.googleplex.com/B88hiRSwcAfeE49
There was a problem hiding this comment.
Done in 0cfa704
Also verified that the added test fails until the changes in dataset.py.
chelsea-lin
approved these changes
May 13, 2025
|
Thanks for submitting this PR. Much appreciated, Tim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while updating the internal version of google-cloud-bigquery. Without this fix, it was causing this test to fail: https://github.com/dbt-labs/dbt-bigquery/blob/0995665e490cdee9c408d26aac8e1c19fefaebe0/tests/unit/test_dataset.py#L25
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕