Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: execute retry tests serially, since they depend on global time #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 20, 2025
Merged

chore: execute retry tests serially, since they depend on global time #2265

merged 8 commits into from
Aug 20, 2025

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 18, 2025 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2264 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Aug 18, 2025
@tswast tswast changed the title chore: migrate test_base retry tests chore: execute retry tests serially, since they depend on global time Aug 18, 2025
tswast
tswast commented Aug 18, 2025
View reviewed changes
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 18, 2025
@tswast tswast marked this pull request as ready for review August 18, 2025 19:23
@tswast tswast requested review from a team as code owners August 18, 2025 19:23
@tswast tswast requested a review from chalmerlowe August 18, 2025 19:23
@tswast

This comment was marked as resolved.

Sign in to view
chalmerlowe
chalmerlowe approved these changes Aug 20, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit d41fd5c into main Aug 20, 2025
28 checks passed
@tswast tswast deleted the issue2264-no-parallel-for-retry-tests branch August 20, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

combination of freezegun and parallel tests causes unit tests to flake
2 participants
@tswast @chalmerlowe