Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: allow for alternative PCA solutions in tests #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

test: allow for alternative PCA solutions in tests #143

merged 1 commit into from
Oct 25, 2023

Conversation

milkshakeiii
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@milkshakeiii milkshakeiii requested review from a team as code owners October 25, 2023 18:14
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 25, 2023
@milkshakeiii milkshakeiii requested a review from tswast October 25, 2023 18:16
@milkshakeiii milkshakeiii changed the title fix: allow for alternative PCA solutions in tests test: allow for alternative PCA solutions in tests Oct 25, 2023
@milkshakeiii milkshakeiii added the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2023
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2023
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 05d7618 into main Oct 25, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the 1025-oncall-bqml-signs branch October 25, 2023 22:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2023
ashleyxuu pushed a commit that referenced this pull request Oct 26, 2023
@milkshakeiii @ashleyxuu
test: allow for alternative PCA solutions in tests (#143)
10c30cb 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milkshakeiii @tswast @bigframes-bot