Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "ci: Disable presubmit LLM tests temporarily (#144)" #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2023
Merged

Revert "ci: Disable presubmit LLM tests temporarily (#144)" #148

merged 2 commits into from
Oct 26, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Oct 26, 2023

This reverts commit 1641aff, which was merged due to automerge label while still being discussed.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi shobsi requested review from a team as code owners October 26, 2023 02:41
@shobsi shobsi requested a review from Genesis929 October 26, 2023 02:41
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 26, 2023
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
@shobsi shobsi mentioned this pull request Oct 26, 2023
Merged
4 tasks
@gcf-merge-on-green gcf-merge-on-green bot merged commit ade505c into main Oct 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the revert-144-shobs-disable-llm-tests branch October 26, 2023 05:12
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
ashleyxuu pushed a commit that referenced this pull request Oct 26, 2023
@shobsi @ashleyxuu
Revert "ci: Disable presubmit LLM tests temporarily (#144)" (#148)
e80abdb 
This reverts commit 1641aff, which was merged due to automerge label while still being discussed.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milkshakeiii milkshakeiii milkshakeiii approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shobsi @milkshakeiii