chore: add error handle for pdf extract and pdf chunk #1490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettWu
reviewed
Mar 13, 2025
|
Can we also add tests as those are already available in PROD now. like #1482 |
e72a4f7 to
ca99b06
Compare
|
ca99b06 to
ee140fc
Compare
GarrettWu
reviewed
Mar 25, 2025
ee140fc to
c4b6aa8
Compare
GarrettWu
reviewed
Mar 26, 2025
|
Generally don't enable auto-merge unless the PR is just trivial. In case the reviewer wants to approve with minor comments to fix. |
GarrettWu
approved these changes
Mar 26, 2025
…s true, display both error message and content, otherwises, display content only
c4b6aa8 to
b6fd13a
Compare
shobsi
pushed a commit
that referenced
this pull request
Mar 28, 2025
* add error handling for pdf chunk * change return type for pdf chunk * add error handling for pdf chunk * introuduce a control variable called verbose for pdf chunk, when it is true, display both error message and content, otherwises, display content only * add pdf extract testcase * add testcase for pdf chunk * code change for pdf extract and pdf chunk, need to fix test * all testcases are clean * update testcase for better readibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add error handle for pdf extract and pdf chunk
add docs and testcase for pdf extract and pdf chunk
testcases are verified: screen/vFUmM6VeAFwhYv9