Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: Factor out exectuor.head method into cache and execute slice #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2025
Merged

refactor: Factor out exectuor.head method into cache and execute slice #1676

merged 2 commits into from
May 1, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Apr 30, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review April 30, 2025 22:11
@TrevorBergeron TrevorBergeron requested review from a team as code owners April 30, 2025 22:11
@TrevorBergeron TrevorBergeron requested a review from jialuoo April 30, 2025 22:11
@TrevorBergeron TrevorBergeron requested review from sycai and removed request for jialuoo May 1, 2025 02:22
sycai
sycai reviewed May 1, 2025
View reviewed changes
bigframes/core/blocks.py Outdated
@@ -69,6 +69,7 @@
import bigframes.exceptions as bfe
import bigframes.operations as ops
import bigframes.operations.aggregations as agg_ops
from bigframes.session import executor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use from bigfreames.session import executor as executors so that its name does not conflict with your local variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

bigframes/session/bq_caching_executor.py Outdated
return
if use_session:
# First, see if we can reuse the existing cache
# TODO: Provide feedback to user on whether new caching action was deemed necessary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can open bugs to track these TODOs? go/todo-style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@TrevorBergeron TrevorBergeron requested a review from sycai May 1, 2025 21:50
@TrevorBergeron TrevorBergeron merged commit 7489c27 into main May 1, 2025
19 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the no_executor_head branch May 1, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sycai sycai sycai approved these changes

Assignees

@liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @sycai @liujiashang