Thanks to visit codestin.com
Credit goes to github.com

Skip to content

revert: use table clone instead of system time for read_gbq_table (#109) #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2023
Merged

revert: use table clone instead of system time for read_gbq_table (#109) #171

merged 1 commit into from
Nov 4, 2023

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Nov 4, 2023

This reverts commit 031f253.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners November 4, 2023 01:27
@tswast tswast requested a review from TrevorBergeron November 4, 2023 01:27
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 4, 2023
@jiaxunwu jiaxunwu merged commit dfcc2d3 into main Nov 4, 2023
@jiaxunwu jiaxunwu deleted the revert-109-b305235665-table-clone branch November 4, 2023 02:44
@tswast
Copy link
Collaborator Author

tswast commented Nov 6, 2023

For context, the reason we reverted #109 is that we very quickly hit the 1000 table clones per table limit. https://cloud.google.com/bigquery/quotas#table_clones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaxunwu jiaxunwu jiaxunwu approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron TrevorBergeron is a code owner automatically assigned from googleapis/api-bigquery-dataframe

+1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @jiaxunwu @ashleyxuu