Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support series.at[row_label] = scalar #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 7, 2023
Merged

feat: support series.at[row_label] = scalar #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c6d9754
feat: support series.at[row_label] = scaler and loc equivalent
Nov 4, 2023
29ec45d
don't change original loc implementation
Nov 4, 2023
29e44a5
fix type in test
Nov 4, 2023
96424c6
improve type hint
Nov 4, 2023
9bf9a88
Merge branch 'main' into b303056774-series-at-setitem-scaler
milkshakeiii Nov 6, 2023
1e8941d
Merge branch 'main' of github.com:googleapis/python-bigquery-datafram…
Nov 6, 2023
187ddf3
Merge branch 'b303056774-series-at-setitem-scaler' of github.com:goog…
Nov 6, 2023
917fdec
Merge branch 'main' into b303056774-series-at-setitem-scaler
milkshakeiii Nov 7, 2023
f488d42
add copy to test
Nov 7, 2023
0d5a6fc
Merge branch 'b303056774-series-at-setitem-scaler' of github.com:goog…
Nov 7, 2023
b82e1fb
Merge branch 'main' into b303056774-series-at-setitem-scaler
milkshakeiii Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions bigframes/core/indexers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,18 @@ def __getitem__(
) -> Union[bigframes.core.scalar.Scalar, bigframes.series.Series]:
return self._series.loc[key]

def __setitem__(
self,
key: LocSingleKey,
value: bigframes.core.scalar.Scalar,
):
if not pd.api.types.is_scalar(value):
raise NotImplementedError(
"series.at.__setitem__ only supports scalar right-hand values. "
f"{constants.FEEDBACK_LINK}"
)
self._series.loc[key] = value


class LocDataFrameIndexer:
def __init__(self, dataframe: bigframes.dataframe.DataFrame):
Expand Down
11 changes: 11 additions & 0 deletions tests/system/small/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,17 @@ def test_loc_setitem_cell(scalars_df_index, scalars_pandas_df_index):
pd.testing.assert_series_equal(bf_original.to_pandas(), pd_original)


def test_at_setitem_row_label_scalar(scalars_dfs):
scalars_df, scalars_pandas_df = scalars_dfs
bf_series = scalars_df["int64_col"]
pd_series = scalars_pandas_df["int64_col"].copy()
bf_series.at[1] = 1000
pd_series.at[1] = 1000
bf_result = bf_series.to_pandas()
pd_result = pd_series.astype("Int64")
pd.testing.assert_series_equal(bf_result, pd_result)


def test_ne_obj_series(scalars_dfs):
scalars_df, scalars_pandas_df = scalars_dfs
col_name = "string_col"
Expand Down