fix: increase recursion limit, cache compilation tree hashes #184
Conversation
bigframes/pandas/__init__.py
Outdated
|
|
||
| # SQL Compilation uses recursive algorithms on deep trees | ||
| # 10M tree depth should be sufficient to generate any sql that is under bigquery limit | ||
| sys.setrecursionlimit(10000000) |
There was a problem hiding this comment.
Let's get the current so that we aren't decreasing the limit (though I expect that to be unlikely)
There was a problem hiding this comment.
done, now doing max for 10000000 and current recursion limit
| return None | ||
|
|
||
| @functools.cached_property | ||
| def _node_hash(self): |
There was a problem hiding this comment.
Let's document this (needed for cached_property and to avoid infinite loop)
There was a problem hiding this comment.
added comment explaining need for this hash impl
| ) | ||
|
|
||
|
|
||
| def test_recursion_limit(scalars_df_index): |
There was a problem hiding this comment.
Might be able to make this a unit test, but as discussed, it is good to exercise ibis here too.
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕