Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Hybrid engine local join support #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

feat: Hybrid engine local join support #1900

merged 1 commit into from
Jul 11, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 10, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review July 11, 2025 00:24
@TrevorBergeron TrevorBergeron requested review from a team as code owners July 11, 2025 00:24
chelsea-lin
chelsea-lin reviewed Jul 11, 2025
View reviewed changes
bigframes/core/compile/polars/compiler.py
left_on = []
right_on = []
for left_ex, right_ex in node.conditions:
left_ex, right_ex = lowering._coerce_comparables(left_ex, right_ex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does polars treat NULL as different each other (similar to pandas or BQ)? I am wondering if Polars needs a _join_condition like compiler too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Polars df.join actually has a very helpful join_nulls (nulls_equal in more recent versions) argument that does exactly what we need

@TrevorBergeron TrevorBergeron added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 11, 2025
@TrevorBergeron TrevorBergeron enabled auto-merge (squash) July 11, 2025 17:40
@TrevorBergeron TrevorBergeron merged commit 1aa7950 into main Jul 11, 2025
24 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the engines_join branch July 11, 2025 17:42
@release-please release-please bot mentioned this pull request Jul 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@ericfe-google ericfe-google

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @chelsea-lin @ericfe-google