Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: make the code samples reflect default bq connection usage #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2023
Merged

docs: make the code samples reflect default bq connection usage #206

merged 2 commits into from
Nov 22, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Nov 15, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 305136837 🦕

@shobsi shobsi requested review from a team as code owners November 15, 2023 02:38
@shobsi shobsi requested review from dandhlee and tswast November 15, 2023 02:38
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Nov 15, 2023
@shobsi shobsi requested a review from ashleyxuu November 22, 2023 22:40
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Nov 22, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 71844b0 into main Nov 22, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the rf-code-sample-default-conn branch November 22, 2023 23:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 22, 2023
@release-please release-please bot mentioned this pull request Nov 22, 2023
Merged
Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
@shobsi @Genesis929
docs: make the code samples reflect default bq connection usage (#206)
d47f5e8 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes internal issue 305136837 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee Awaiting requested review from dandhlee dandhlee is a code owner automatically assigned from googleapis/python-samples-reviewers

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery-dataframe

1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shobsi @ashleyxuu