-
Notifications
You must be signed in to change notification settings - Fork 60
feat: Add ai_generate_bool to the bigframes.bigquery package #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get the dot in there to match SQL, so let's do it. :-)
bigframes/bigquery/__init__.py
Outdated
|
||
_functions = [ | ||
# ai ops | ||
ai_generate_bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ai_generate_bool, | |
ai, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, if we do this, I think we'll want to add the ai submodule to the docs,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. I'm not familiar with how docs are setup. Please take a look to make sure I get everything correct. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Tim Sweña (Swast) <[email protected]>
Input: ("str1", series1, "str2", "str3", series2) | ||
Output: ["str1", None, "str2", "str3", None], [series1, series2] | ||
""" | ||
if not isinstance(prompt, (list, tuple, series.Series)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we call the batch_convert_to_dataframe
method https://github.com/googleapis/python-bigquery-dataframes/blob/main/bigframes/bigquery/_operations/search.py#L230 or similar here so that pandas objects are accepted too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do that in a separate PR.
Only the Ibis compiler is updated. The next step is to update the SQLGlot compiler too.
Internal issue: b/443853093