feat: Add __dataframe__ interchange support #2063
Merged
+335
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tswast
approved these changes
Sep 15, 2025
|
|
||
| @functools.cache | ||
| def _arrow_column(self): | ||
| # Conservatively downloads the whole underlying dataframe |
There was a problem hiding this comment.
Do we have a TODO / issue to collect data regarding how common it is to get one column vs many?
| return self._dataframe._arrow_dataframe().get_column(self._pos) | ||
|
|
||
| def size(self) -> int: | ||
| return self._arrow_column().size() |
There was a problem hiding this comment.
Likewise, theoretically we could calculate this without downloading any data. I think it'd be worth tracking an evaluation whether this should be optimized.
There was a problem hiding this comment.
Love the new version of this, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕