feat: support pd.cut() for array-like type #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efa182a to
d080c70
Compare
d080c70 to
414e2b4
Compare
GarrettWu
approved these changes
Sep 10, 2025
|
|
||
| def cut( | ||
| x: bigframes.series.Series, | ||
| x, |
There was a problem hiding this comment.
Do we want to drop the type hints? Though pandas doesn't have for this parameter, giving hints helps users to know what to pass in.
There was a problem hiding this comment.
Good point. I'm keeping x untyped to remain consistent with Series.__init__(), which also doesn't have type hints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 329866195 🦕