Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: return a DataFrame containing query stats for all non-SELECT statements #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 15, 2025
Merged

fix: return a DataFrame containing query stats for all non-SELECT statements #2071

merged 5 commits into from
Sep 15, 2025
+110 −28

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Sep 11, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue b/444282709 🦕

@tswast tswast requested review from a team as code owners September 11, 2025 15:15
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 11, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Sep 11, 2025
@tswast
Copy link
Collaborator Author

tswast commented Sep 12, 2025

Samples failures

  • samples/snippets/bqml_getting_started_test.py::test_bqml_getting_started -- this seems unrelated. Looks like a BQML issue where it's not returning the expected columns
  • create_single_timeseries_forecasting_model_test.py::test_create_single_timeseries KeyError date This might need more investigation.

@tswast
Copy link
Collaborator Author

tswast commented Sep 12, 2025 •
edited
Loading

samples/snippets/create_single_timeseries_forecasting_model_test.py is failing on HEAD, so the error wasn't introduced by this test. I think the underlying data changed.

Hmm... Except I still see the date column here: https://console.cloud.google.com/bigquery?ws=!1m5!1m4!4m3!1sbigquery-public-data!2sgoogle_analytics_sample!3sga_sessions_20160916

Edit: This has been fixed. It was a problem with a new table added to the dataset.

@tswast tswast merged commit a52b913 into main Sep 15, 2025
24 of 25 checks passed
@tswast tswast deleted the b444282709-read_gbq_query-create-or-replace-view branch September 15, 2025 19:28
@release-please release-please bot mentioned this pull request Sep 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees

@shobsi shobsi

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @TrevorBergeron @shobsi