Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: deflake ai_gen_bool multimodel test #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 16, 2025
Merged

fix: deflake ai_gen_bool multimodel test #2085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c94744
fix: deflake ai_gen_bool multimodel test
sycai Sep 15, 2025
c98c9e7
fix lint
sycai Sep 15, 2025
97fa173
fix doctest too
sycai Sep 15, 2025
1ce7a32
consolidates tests under system/small
sycai Sep 15, 2025
bf7d249
Merge branch 'main' into sycai_ai_gen_bool_mm_fix
sycai Sep 15, 2025
c9fec4c
fix doctest
sycai Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions bigframes/bigquery/_operations/ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,30 +47,13 @@ def generate_bool(
... "col_1": ["apple", "bear", "pear"],
... "col_2": ["fruit", "animal", "animal"]
... })
>>> bbq.ai_generate_bool((df["col_1"], " is a ", df["col_2"]))
>>> bbq.ai.generate_bool((df["col_1"], " is a ", df["col_2"]))
0 {'result': True, 'full_response': '{"candidate...
1 {'result': True, 'full_response': '{"candidate...
2 {'result': False, 'full_response': '{"candidat...
dtype: struct<result: bool, full_response: string, status: string>[pyarrow]

>>> bbq.ai_generate_bool((df["col_1"], " is a ", df["col_2"])).struct.field("result")
0 True
1 True
2 False
Name: result, dtype: boolean

>>> model_params = {
... "generation_config": {
... "thinking_config": {
... "thinking_budget": 0
... }
... }
... }
>>> bbq.ai_generate_bool(
... (df["col_1"], " is a ", df["col_2"]),
... endpoint="gemini-2.5-pro",
... model_params=model_params,
... ).struct.field("result")
>>> bbq.ai.generate_bool((df["col_1"], " is a ", df["col_2"])).struct.field("result")
0 True
1 True
2 False
Expand Down
13 changes: 0 additions & 13 deletions tests/system/large/bigquery/__init__.py
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions tests/system/large/bigquery/test_ai.py
View file
Open in desktop

This file was deleted.

60 changes: 45 additions & 15 deletions tests/system/small/bigquery/test_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@
import sys

import pandas as pd
import pandas.testing
import pyarrow as pa
import pytest

from bigframes import series
import bigframes.bigquery as bbq
import bigframes.pandas as bpd

Expand All @@ -27,15 +28,17 @@ def test_ai_generate_bool(session):
s2 = bpd.Series(["fruit", "tree"], session=session)
prompt = (s1, " is a ", s2)

result = bbq.ai.generate_bool(prompt, endpoint="gemini-2.5-flash").struct.field(
"result"
)
result = bbq.ai.generate_bool(prompt, endpoint="gemini-2.5-flash")

pandas.testing.assert_series_equal(
result.to_pandas(),
pd.Series([True, False], name="result"),
check_dtype=False,
check_index=False,
assert _contains_no_nulls(result)
assert result.dtype == pd.ArrowDtype(
pa.struct(
(
pa.field("result", pa.bool_()),
pa.field("full_response", pa.string()),
pa.field("status", pa.string()),
)
)
)


Expand All @@ -52,11 +55,38 @@ def test_ai_generate_bool_with_model_params(session):

result = bbq.ai.generate_bool(
prompt, endpoint="gemini-2.5-flash", model_params=model_params
).struct.field("result")
)

assert _contains_no_nulls(result)
assert result.dtype == pd.ArrowDtype(
pa.struct(
(
pa.field("result", pa.bool_()),
pa.field("full_response", pa.string()),
pa.field("status", pa.string()),
)
)
)


pandas.testing.assert_series_equal(
result.to_pandas(),
pd.Series([True, False], name="result"),
check_dtype=False,
check_index=False,
def test_ai_generate_bool_multi_model(session):
df = session.from_glob_path(
"gs://bigframes-dev-testing/a_multimodel/images/*", name="image"
)

result = bbq.ai.generate_bool((df["image"], " contains an animal"))

assert _contains_no_nulls(result)
assert result.dtype == pd.ArrowDtype(
pa.struct(
(
pa.field("result", pa.bool_()),
pa.field("full_response", pa.string()),
pa.field("status", pa.string()),
)
)
)


def _contains_no_nulls(s: series.Series) -> bool:
return len(s) == s.count()