Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes interbal issue 312493159 🦕

@ashleyxuu ashleyxuu requested review from a team as code owners November 23, 2023 00:14
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 23, 2023
@ashleyxuu ashleyxuu requested review from TrevorBergeron and tswast and removed request for stevewalker-de November 23, 2023 00:15
@ashleyxuu ashleyxuu changed the title fix: df snapshots lookup fix: add df snapshots lookup for read_gbq Nov 23, 2023
index_col: Iterable[str] | str = (),
col_order: Iterable[str] = (),
max_results: Optional[int] = None,
use_cache: bool = True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolving. You didn't populate the QueryJobConfig.use_query_cache property as I requested.

index_col: Iterable[str] | str = (),
col_order: Iterable[str] = (),
max_results: Optional[int] = None,
use_cache: bool = True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolving. You didn't populate the QueryJobConfig.use_query_cache property as I requested.

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashleyxuu ashleyxuu added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 29, 2023
@ashleyxuu ashleyxuu added the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2023
@bigframes-bot bigframes-bot removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 29, 2023
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2023
@ashleyxuu ashleyxuu merged commit d0d9b84 into main Nov 29, 2023
@ashleyxuu ashleyxuu deleted the ashleyxu-df-snapshots-lookup branch November 29, 2023 17:15
Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants