fix: fix value_counts column label for normalize=True #245
Conversation
| subset, normalize=normalize, ascending=ascending, dropna=dropna | ||
| ) | ||
|
|
||
| # Older pandas version may not have these values, bigframes tries to emulate 2.0+ |
There was a problem hiding this comment.
Let's remove this from test_series as well https://github.com/search?q=repo%3Agoogleapis%2Fpython-bigquery-dataframes%20%22Older%20pandas%20version%20may%20not%20have%20these%20values%22&type=code
There was a problem hiding this comment.
Thanks, just one one more test test_value_counts_w_cut in test_series.py
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕