Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: pin prerelease tests to pandas 2.1.3 to unblock e2e tests #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2023
Merged

fix: pin prerelease tests to pandas 2.1.3 to unblock e2e tests #268

merged 3 commits into from
Dec 12, 2023

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Dec 11, 2023 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix: exclude pandas 2.1.4 from prerelease tests to unblock e2e tests
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 315852455 🦕

@shobsi shobsi requested review from a team as code owners December 11, 2023 22:13
@shobsi shobsi requested a review from GarrettWu December 11, 2023 22:13
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 11, 2023
@shobsi shobsi requested a review from tswast December 11, 2023 22:14
parthea
parthea reviewed Dec 11, 2023
View reviewed changes
@shobsi shobsi added the automerge Merge the pull request once unit tests and other checks pass. label Dec 11, 2023
@shobsi shobsi merged commit b02fc2c into main Dec 12, 2023
@shobsi shobsi deleted the shobs-pass-e2e branch December 12, 2023 02:34
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 12, 2023
Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
@shobsi @Genesis929
fix: pin prerelease tests to pandas 2.1.3 to unblock e2e tests (#268)
a187bcc 
* fix: pin prerelease tests to pandas 2.1.3 to unblock e2e tests

* specify excluded pandas version differently, to automatically test on a
release
@shobsi shobsi mentioned this pull request Feb 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea left review comments

@tswast tswast tswast approved these changes

@GarrettWu GarrettWu GarrettWu approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shobsi @tswast @parthea @GarrettWu