chore: ensure colab sample notebooks are tested #351

tswast · 2024-01-26T17:13:21Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes internal issue 321013333
🦕

review-notebook-app · 2024-01-26T18:50:23Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

tswast · 2024-01-26T19:40:52Z

Tested locally, and the session is now passing:

$ nox -r -s notebook-3.9
nox > Running session notebook-3.9
nox > Re-using existing virtual environment at .nox/notebook-3-9.
nox > python -m pip install -e '.[all]'
nox > python -m pip install pytest pytest-xdist pytest-retry nbmake google-cloud-aiplatform matplotlib seaborn
nox > python /usr/local/google/home/swast/src/bigframes/scripts/notebooks_fill_params.py notebooks/regression/easy_linear_regression.ipynb notebooks/regression/sklearn_linear_regression.ipynb notebooks/dataframes/dataframe.ipynb notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb notebooks/generative_ai/large_language_models.ipynb notebooks/generative_ai/bq_dataframes_llm_code_generation.ipynb notebooks/visualization/bq_dataframes_covid_line_graphs.ipynb notebooks/remote_functions/remote_function.ipynb notebooks/getting_started/getting_started_bq_dataframes.ipynb
nox > py.test --nbmake --nbmake-timeout=900 -nauto notebooks/regression/easy_linear_regression.ipynb notebooks/regression/sklearn_linear_regression.ipynb notebooks/dataframes/dataframe.ipynb notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb notebooks/generative_ai/large_language_models.ipynb notebooks/generative_ai/bq_dataframes_llm_code_generation.ipynb notebooks/visualization/bq_dataframes_covid_line_graphs.ipynb notebooks/remote_functions/remote_function.ipynb notebooks/getting_started/getting_started_bq_dataframes.ipynb
============================================================ test session starts ============================================================
platform linux -- Python 3.9.16, pytest-7.4.4, pluggy-1.4.0
rootdir: /usr/local/google/home/swast/src/bigframes
configfile: pytest.ini
plugins: retry-1.6.1, xdist-3.5.0, mock-3.12.0, nbmake-1.4.6
12 workers [9 items]      
.........                                                                                                                             [100%]
======================================================= 9 passed in 751.43s (0:12:31) =======================================================
nox > python /usr/local/google/home/swast/src/bigframes/scripts/notebooks_restore_from_backup.py notebooks/regression/easy_linear_regression.ipynb notebooks/regression/sklearn_linear_regression.ipynb notebooks/dataframes/dataframe.ipynb notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb notebooks/generative_ai/large_language_models.ipynb notebooks/generative_ai/bq_dataframes_llm_code_generation.ipynb notebooks/visualization/bq_dataframes_covid_line_graphs.ipynb notebooks/remote_functions/remote_function.ipynb notebooks/getting_started/getting_started_bq_dataframes.ipynb
nox > py.test --nbmake --nbmake-timeout=900 notebooks/location/regionalized.ipynb
nox > py.test --nbmake --nbmake-timeout=900 notebooks/location/regionalized.ipynb
nox > py.test --nbmake --nbmake-timeout=900 notebooks/location/regionalized.ipynb
nox > py.test --nbmake --nbmake-timeout=900 notebooks/location/regionalized.ipynb
nox > py.test --nbmake --nbmake-timeout=900 notebooks/location/regionalized.ipynb
nox > py.test --nbmake --nbmake-timeout=900 notebooks/location/regionalized.ipynb
============================================================ test session starts ============================================================
platform linux -- Python 3.9.16, pytest-7.4.4, pluggy-1.4.0
rootdir: /usr/local/google/home/swast/src/bigframes
configfile: pytest.ini
plugins: retry-1.6.1, xdist-3.5.0, mock-3.12.0, nbmake-1.4.6
collected 1 item                                                                                                                            

notebooks/location/regionalized.ipynb ============================================================ test session starts ============================================================
platform linux -- Python 3.9.16, pytest-7.4.4, pluggy-1.4.0
rootdir: /usr/local/google/home/swast/src/bigframes
configfile: pytest.ini
plugins: retry-1.6.1, xdist-3.5.0, mock-3.12.0, nbmake-1.4.6
collecting ... ============================================================ test session starts ============================================================
platform linux -- Python 3.9.16, pytest-7.4.4, pluggy-1.4.0
collected 1 item                                                                                                                            

notebooks/location/regionalized.ipynb ============================================================ test session starts ============================================================
platform linux -- Python 3.9.16, pytest-7.4.4, pluggy-1.4.0
rootdir: /usr/local/google/home/swast/src/bigframes
configfile: pytest.ini
plugins: retry-1.6.1, xdist-3.5.0, mock-3.12.0, nbmake-1.4.6
collecting ... rootdir: /usr/local/google/home/swast/src/bigframes
configfile: pytest.ini
plugins: retry-1.6.1, xdist-3.5.0, mock-3.12.0, nbmake-1.4.6
collecting ... ============================================================ test session starts ============================================================
platform linux -- Python 3.9.16, pytest-7.4.4, pluggy-1.4.0
collected 1 item                                                                                                                            

notebooks/location/regionalized.ipynb rootdir: /usr/local/google/home/swast/src/bigframes
configfile: pytest.ini
plugins: retry-1.6.1, xdist-3.5.0, mock-3.12.0, nbmake-1.4.6
collected 1 item                                                                                                                            

collected 1 item                                                                                                                            

notebooks/location/regionalized.ipynb ============================================================ test session starts ============================================================
platform linux -- Python 3.9.16, pytest-7.4.4, pluggy-1.4.0
rootdir: /usr/local/google/home/swast/src/bigframes
configfile: pytest.ini
plugins: retry-1.6.1, xdist-3.5.0, mock-3.12.0, nbmake-1.4.6
collected 1 item                                                                                                                            

notebooks/location/regionalized.ipynb .                                                                                               [100%]

======================================================= 1 passed in 122.27s (0:02:02) =======================================================
.                                                                                               [100%]

======================================================= 1 passed in 132.72s (0:02:12) =======================================================
.                                                                                               [100%]

======================================================= 1 passed in 135.59s (0:02:15) =======================================================
.                                                                                               [100%]

======================================================= 1 passed in 139.97s (0:02:19) =======================================================
.                                                                                               [100%]

======================================================= 1 passed in 147.41s (0:02:27) =======================================================
.                                                                                               [100%]

======================================================= 1 passed in 189.72s (0:03:09) =======================================================
nox > Session notebook-3.9 was successful.

ashleyxuu · 2024-01-26T19:29:02Z

noxfile.py

        "py.test",
        "--nbmake",
-        "--nbmake-timeout=600",
+        "--nbmake-timeout=900",  # 15 minutes


Is there a reason why we increase the timeout limit specifically to 15 mins. Do we test the boundary?

The default was too slow for the LLM sample when I tested locally.

ashleyxuu · 2024-01-26T19:42:48Z

noxfile.py

-        "notebooks/getting_started/getting_started_bq_dataframes.ipynb",
-        "notebooks/getting_started/ml_fundamentals_bq_dataframes.ipynb",
-        "notebooks/generative_ai/bq_dataframes_llm_code_generation.ipynb",
-        "notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb",


Do we still need DATASET when running bf.read_gbq()?

I don't know what you mean. DATASET variable doesn't appear in https://github.com/googleapis/python-bigquery-dataframes/blob/677f0146acf19def88fddbeb0527a078458948ae/notebooks/generative_ai/bq_dataframes_llm_kmeans.ipynb

We read it here, right?
https://screenshot.googleplex.com/32s3pbtqnWZakiM

That's a read, which doesn't need to be parametrized. DATASET is used a a destination in the other samples.

Thanks got it!

…ests

…hon-bigquery-dataframes into b321013333-notebook-tests

tswast · 2024-01-29T16:33:02Z

Looks like bq_dataframes_llm_code_generation had a failure (https://fusion2.corp.google.com/invocations/516e88fd-c9b4-4960-82a4-22bddcab71e9/targets/bigframes%2Fpresubmit%2Fe2e/log). Trying a change that will hopefully help regarding the GCS bucket that sample creates.

tswast · 2024-01-29T17:27:05Z

Still have a failing notebook test after dfee838 I'll maybe revert that commit and exclude that particular notebook for now.

This reverts commit dfee838.

gcf-merge-on-green · 2024-01-30T01:36:44Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

chore: ensure colab sample notebooks are tested

3593c7c

tswast requested review from a team as code owners January 26, 2024 17:13

tswast requested a review from GarrettWu January 26, 2024 17:13

product-auto-label bot added the size: m Pull request size is medium. label Jan 26, 2024

tswast requested review from ashleyxuu and removed request for GarrettWu January 26, 2024 17:13

product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Jan 26, 2024

tswast added 4 commits January 26, 2024 17:16

make restore from backup robust to when the backup doesn't exist

f91ce03

fix path to notebook params scripts

a3ec546

exclude notebooks that need parameters other than project_id

5904960

add missing dependencies

b5cf2ed

tswast added 2 commits January 26, 2024 19:20

notebook testing fixes

0e8ece0

Merge branch 'main' into b321013333-notebook-tests

ba097bf

ashleyxuu reviewed Jan 26, 2024

View reviewed changes

tswast requested a review from ashleyxuu January 29, 2024 16:21

ashleyxuu approved these changes Jan 29, 2024

View reviewed changes

tswast added 3 commits January 29, 2024 16:31

add sleep to avoid some bucket flakiness

dfee838

Merge remote-tracking branch 'origin/main' into b321013333-notebook-t…

f72dd2e

…ests

Merge branch 'b321013333-notebook-tests' of github.com:googleapis/pyt…

53b0e8a

…hon-bigquery-dataframes into b321013333-notebook-tests

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jan 29, 2024

tswast added 2 commits January 29, 2024 17:31

Revert "add sleep to avoid some bucket flakiness"

c92b9da

This reverts commit dfee838.

exclude bq_dataframes_llm_code_generation sample

e5d9191

product-auto-label bot added the size: m Pull request size is medium. label Jan 29, 2024

product-auto-label bot removed the size: l Pull request size is large. label Jan 29, 2024

Merge branch 'main' into b321013333-notebook-tests

4bc0cdb

tswast added the automerge Merge the pull request once unit tests and other checks pass. label Jan 29, 2024

Merge branch 'main' into b321013333-notebook-tests

ecd59c8

gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 30, 2024

tswast merged commit 5aad3a1 into main Jan 30, 2024

tswast deleted the b321013333-notebook-tests branch January 30, 2024 16:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: ensure colab sample notebooks are tested #351

chore: ensure colab sample notebooks are tested #351

Uh oh!

tswast commented Jan 26, 2024

Uh oh!

review-notebook-app bot commented Jan 26, 2024

Uh oh!

tswast commented Jan 26, 2024

Uh oh!

ashleyxuu Jan 26, 2024

Uh oh!

tswast Jan 26, 2024

Uh oh!

ashleyxuu Jan 26, 2024

Uh oh!

tswast Jan 26, 2024

Uh oh!

ashleyxuu Jan 26, 2024 •

edited

Loading

Uh oh!

tswast Jan 29, 2024

Uh oh!

ashleyxuu Jan 29, 2024

Uh oh!

tswast commented Jan 29, 2024 •

edited

Loading

Uh oh!

tswast commented Jan 29, 2024

Uh oh!

gcf-merge-on-green bot commented Jan 30, 2024

Uh oh!

Uh oh!

chore: ensure colab sample notebooks are tested #351

chore: ensure colab sample notebooks are tested #351

Uh oh!

Conversation

tswast commented Jan 26, 2024

Uh oh!

review-notebook-app bot commented Jan 26, 2024

Uh oh!

tswast commented Jan 26, 2024

Uh oh!

ashleyxuu Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

tswast Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

ashleyxuu Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

tswast Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

ashleyxuu Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tswast Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

ashleyxuu Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

tswast commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tswast commented Jan 29, 2024

Uh oh!

gcf-merge-on-green bot commented Jan 30, 2024

Uh oh!

Uh oh!

ashleyxuu Jan 26, 2024 •

edited

Loading

tswast commented Jan 29, 2024 •

edited

Loading