Thanks to visit codestin.com
Credit goes to github.com

Skip to content

deps: add minimum version constraint for sqlglot to 19.9.0 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2024
Merged

deps: add minimum version constraint for sqlglot to 19.9.0 #389

merged 2 commits into from
Feb 23, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Feb 23, 2024

This shouldn't be necessary, as sqlglot is only used as a transitive dependency through ibis-framework, but in setting the constraints, we can have greater assurance that sqlglot is upgraded alongside bigframes in existing environments.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #315 🦕

@tswast
deps: add minimum version constraint for sqlglot to 19.9.0
1daf8cc 
This shouldn't be necessary, as sqlglot is only used as a transitive
dependency through ibis-framework, but in setting the constraints, we
can have greater assurance that sqlglot is upgraded alongside bigframes
in existing environments.
@tswast tswast requested review from a team as code owners February 23, 2024 17:22
@tswast tswast requested a review from junyazhang February 23, 2024 17:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 23, 2024
@tswast tswast requested a review from chelsea-lin February 23, 2024 17:23
@tswast
Copy link
Collaborator Author

tswast commented Feb 23, 2024

prerelease failures appear to be due to new pandas release pandas==2.2.1. We need to fix our tests for pandas 2.2.x still (internal issue b/322845272)

chelsea-lin
chelsea-lin approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit 8b62d77 into main Feb 23, 2024
@tswast tswast deleted the issue315-sqlglot branch February 23, 2024 19:20
@release-please release-please bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@junyazhang junyazhang Awaiting requested review from junyazhang junyazhang is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlglot.errors.ParseError for sample from website
2 participants
@tswast @chelsea-lin