Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: exclude pandas 2.2.x from testing #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 23, 2024
Merged

chore: exclude pandas 2.2.x from testing #391

merged 4 commits into from
Feb 23, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Feb 23, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 322845272 🦕

@tswast tswast requested a review from shobsi February 23, 2024 19:11
@tswast tswast requested review from a team as code owners February 23, 2024 19:11
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 23, 2024
chelsea-lin
chelsea-lin approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Feb 23, 2024
shobsi
shobsi reviewed Feb 23, 2024
View reviewed changes
noxfile.py Outdated
# https://github.com/googleapis/python-bigquery-dataframes/issues/337
# are resolved
"pandas!=2.1.4, !=2.2.0rc0, !=2.2.0",
"pandas<2.1.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI we have been following != approach to track the exact breaking changes with each release via the associated follow up items (in the comments above) based on the following feedback.

#268 (comment)

shobsi
shobsi approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@shobsi shobsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have narrowed down a new breaking issue in 2.2.1, worth adding in the comments like other excluded versions

@tswast
Copy link
Collaborator Author

tswast commented Feb 23, 2024

If we have narrowed down a new breaking issue in 2.2.1, worth adding in the comments like other excluded versions

I don't think it's anything new compared to 2.2.0 as far as I can tell.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 1040dff into main Feb 23, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the b322845272-pandas-2.2-exclude branch February 23, 2024 20:50
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobsi shobsi shobsi approved these changes

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @shobsi @chelsea-lin