Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: any() on empty set now correctly returns False #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: any() on empty set now correctly returns False #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5489eb4
fix: any() on empty set now correctly returns False
TrevorBergeron Mar 19, 2024
6365606
Merge branch 'main' into empty_index
TrevorBergeron Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bigframes/core/compile/aggregate_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ def _(
result = _is_true(column).any()
return cast(
ibis_types.BooleanScalar,
_apply_window_if_present(result, window).fillna(ibis_types.literal(True)),
_apply_window_if_present(result, window).fillna(ibis_types.literal(False)),
)


Expand Down
4 changes: 4 additions & 0 deletions tests/system/small/test_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ def test_index_has_duplicates(scalars_df_index, scalars_pandas_df_index):
assert bf_result == pd_result


def test_index_empty_has_duplicates():
assert not bpd.Index([]).has_duplicates


def test_index_values(scalars_df_index, scalars_pandas_df_index):
bf_result = scalars_df_index.index.values
pd_result = scalars_pandas_df_index.index.values
Expand Down