feat: add df.unstack #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shobsi
reviewed
Sep 29, 2023
| ) | ||
|
|
||
|
|
||
| def test_column_multi_index_unstack(scalars_df_index, scalars_pandas_df_index): |
There was a problem hiding this comment.
[nit] would test_multi_column_unstack better represent this test?
There was a problem hiding this comment.
My naming convention is based on the initial dataframe object, column_multi_index indicating that the initial column axis is a multi-index. Open to changing this convention, but it is inline with how I've named the tests so far.
| ) | ||
| pd_result = hockey_pandas_df.set_index( | ||
| ["team_name", "season", "position"] | ||
| ).unstack() |
There was a problem hiding this comment.
I think it would be worth testing for all levels: {-3, -2, -1, 0, 1, 2}
There was a problem hiding this comment.
I don't support levels param yet. Will add levels support to stack() and unstack() in a later pr.
shobsi
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕