Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: update owlbot script to prevent silent failures at s.replace #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2024
Merged

chore: update owlbot script to prevent silent failures at s.replace #889

merged 3 commits into from
Aug 13, 2024

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@chelsea-lin chelsea-lin requested a review from tswast August 7, 2024 20:25
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 7, 2024
@chelsea-lin chelsea-lin marked this pull request as ready for review August 7, 2024 21:51
@chelsea-lin chelsea-lin requested review from a team as code owners August 7, 2024 21:51
@chelsea-lin chelsea-lin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 8, 2024
@tswast tswast requested a review from parthea August 9, 2024 19:46
@chelsea-lin chelsea-lin added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_fixdoc branch from 7587485 to 5724f69 Compare August 12, 2024 20:17
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_fixdoc branch from a60feb5 to 38c3070 Compare August 12, 2024 21:40
@chelsea-lin
Copy link
Contributor Author

Running the owl bot post processor locally:

docker pull gcr.io/cloud-devrel-public-resources/owlbot-python:latest
docker run --user $(id -u):$(id -g) --rm -v $(pwd):/repo -w /repo gcr.io/cloud-devrel-public-resources/owlbot-python:latest

@chelsea-lin chelsea-lin merged commit 6dff860 into main Aug 13, 2024
@chelsea-lin chelsea-lin deleted the main_chelsealin_fixdoc branch August 13, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@parthea parthea parthea approved these changes

Assignees

@TrevorBergeron TrevorBergeron

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chelsea-lin @tswast @parthea @TrevorBergeron @bigframes-bot