Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: implement bigframes.bigquery.json_extract_array #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 23, 2024
Merged

feat: implement bigframes.bigquery.json_extract_array #910

merged 5 commits into from
Aug 23, 2024

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented Aug 21, 2024

This is needed to implement support for array return types in remote functions.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shobsi
feat: implement bigframes.bigquery.json_extract_array
991c3e4 
This id needed to implement support for array return types in remote
functions.
@shobsi shobsi requested a review from chelsea-lin August 21, 2024 17:42
@shobsi shobsi requested review from a team as code owners August 21, 2024 17:42
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 21, 2024
chelsea-lin
chelsea-lin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests are passed and left small comments can be addressed.

@shobsi shobsi merged commit 575a29e into main Aug 23, 2024
23 checks passed
@shobsi shobsi deleted the shobs-json-extract-array branch August 23, 2024 06:56
@release-please release-please bot mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@TrevorBergeron TrevorBergeron

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shobsi @chelsea-lin @TrevorBergeron