Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ensure BIGNUMERIC type is used if scale > 9 in Decimal values #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: ensure BIGNUMERIC type is used if scale > 9 in Decimal values #844

merged 1 commit into from
Jan 6, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jan 3, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Ensures fix for googleapis/python-bigquery#1650 makes its way to pandas-gbq as well.
Unblocks googleapis/python-bigquery#2095
🦕

@tswast tswast requested review from a team as code owners January 3, 2025 19:35
@tswast tswast requested a review from chalmerlowe January 3, 2025 19:35
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Jan 3, 2025
@tswast tswast mentioned this pull request Jan 3, 2025
Merged
4 tasks
chalmerlowe
chalmerlowe approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast merged commit d2f32df into main Jan 6, 2025
25 checks passed
@tswast tswast deleted the tswast-bignumeric branch January 6, 2025 16:49
@release-please release-please bot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @chalmerlowe @PhongChuong