fix: updates _get_transitive_schema_fields and tests #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
May 9, 2025
|
|
||
| test_cases = [ | ||
| ( | ||
| "STRUCT field, not REPEATED, with sub-fields, should recurse", |
There was a problem hiding this comment.
[Optional] Generally, I use pytest.param() with an ID argument instead of a description. That makes it a little easier to select a particular test. See
for an example.
There was a problem hiding this comment.
Good point, thanks for the reminder on this option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a line to the
_get_transitive_schema_fieldsfunction to correct an issue with dot notation in column names.Also adds a test suite of tests to exercise the new functionality.
Fixes internal issue #406556097 🦕