Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 12, 2025. It is now read-only.

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Aug 25, 2021

Fixes #280.

@plamut plamut requested review from parthea and a team August 25, 2021 10:07
@plamut plamut requested a review from a team as a code owner August 25, 2021 10:07
@plamut plamut requested review from tswast and removed request for a team August 25, 2021 10:07
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Aug 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2021
@plamut
Copy link
Contributor Author

plamut commented Aug 25, 2021

There are still some references to master left, but all of them in URLs to repos that have not migrated yet. I left those out for now to not cause any unnecessary 404 errors for the end users.

Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised you didn't have to add replacments to owlbot.py to make these changes stick. Is the bot not configured to run on PRs in this repository?

@plamut
Copy link
Contributor Author

plamut commented Aug 25, 2021

I ran this script, but apparently it did not find and "master" patterns and thus didn't make any replacements?

(searching for "master" in the codebase did not yield anything apart from a few URLs to repos that have not done the migration yet)

@tseaver
Copy link
Contributor

tseaver commented Aug 25, 2021

@plamut I don't see that the Owlbot Post Processor check is configured here: if it ran, I think it would revert at least some of your changes here to templated files. @parthea can you investigate?

@plamut
Copy link
Contributor Author

plamut commented Aug 25, 2021

Putting this on hold as well.

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 25, 2021
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021
@parthea
Copy link
Contributor

parthea commented Aug 25, 2021

I've added the owlbot:run label which should trigger owlbot to run. It should have been triggered automatically but I have noticed that there is the odd time that I need to add the label to get it to run.

@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021
@parthea
Copy link
Contributor

parthea commented Aug 25, 2021

The replacements need to be added owlbot.py in order to prevent owlbot from reverting the changes.

@parthea
Copy link
Contributor

parthea commented Aug 25, 2021

Hi @plamut , Please let me know if you have any questions.

@plamut plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 25, 2021
@plamut plamut requested a review from tseaver August 25, 2021 20:08
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 25, 2021
@plamut
Copy link
Contributor Author

plamut commented Aug 25, 2021

Hmm, where are the samples CI checks? Noticed the same on a related Pub/Sub PR.

@plamut plamut deleted the branch googleapis:main August 26, 2021 11:29
@plamut plamut closed this Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants