Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add retry policy for connection #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: add retry policy for connection #906

wants to merge 9 commits into from

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Mar 7, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@Linchin Linchin requested review from a team as code owners March 7, 2025 21:24
@Linchin Linchin requested a review from tswast March 7, 2025 21:24
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Mar 7, 2025
@Linchin Linchin marked this pull request as draft March 7, 2025 21:24
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. label Mar 7, 2025
tswast
tswast reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you want me to take a look at this. I think some retry logic for starting the connection could be useful. As we discussed previously, moving to ResumableBidiRpc (https://github.com/googleapis/python-api-core/blob/1ca7973a395099403be1a99c7c4583a8f22d5d8e/google/api_core/bidi.py#L366) is what will be needed to restart connections partway. It'll require some logic to make sure we resend all requests that were in flight and not acknowledged.

@Linchin
Copy link
Contributor Author

Linchin commented Mar 27, 2025

@tswast It would be awesome if you could take a look! I will let you know once the PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linchin @tswast @suzmue