Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Consistency polling + restore table for sync client in admin #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gkevinzheng merged 4 commits into from
May 21, 2025
Merged

feat: Consistency polling + restore table for sync client in admin #1117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba3f596
feat: Prototyped handwritten layer
gkevinzheng Apr 30, 2025
30ac2f7
Added newlines
gkevinzheng Apr 30, 2025
c853e16
linting
gkevinzheng Apr 30, 2025
fe1c6ed
Added docstrings for restore table and consistency token polling;
gkevinzheng May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions google/cloud/bigtable/admin_v2/overlay/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Copyright 2025 Google LLC.
Copy link
Contributor

@daniel-sanche daniel-sanche May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about the gapic folders in the file structure:

google
    cloud
        bigtable
            data
            admin
            admin_v2
        bigtable_v2

I remember some discussions around this before, but it still seems a bit awkward. Has this been locked in?

#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# This directory and all its subdirectories are the only handwritten
# components of the otherwise autogenerated google/cloud/bigtable/admin_v2.
# The purpose of the overlay directory is to add additional functionality to
# the autogenerated library while preserving its developer experience. These
# handwritten additions currently consist of the following:
#
# 1. TODO: Document final GcRule design choice here
# 2. An LRO class for restore_table that exposes an Operation for
# OptimizeRestoreTable, if that LRO exists.
# 3. New methods (wait_for_consistency and wait_for_replication) that return
# a polling future class for automatically polling check_consistency.
#
# This directory is structured to mirror that of a typical autogenerated library (e.g.
# services/types subdirectories), and the aforementioned handwritten additions are
# currently implemented as either types under overlay/types or in methods in an overwritten
# client class under overlay/services.

from .types import (
RestoreTableOperation,
CheckConsistencyPollingFuture,
)

from .services.bigtable_table_admin import (
BigtableTableAdminClient,
)

__all__ = (
"RestoreTableOperation",
"CheckConsistencyPollingFuture",
"BigtableTableAdminClient",
)
13 changes: 13 additions & 0 deletions google/cloud/bigtable/admin_v2/overlay/services/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Copyright 2025 Google LLC.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
19 changes: 19 additions & 0 deletions google/cloud/bigtable/admin_v2/overlay/services/bigtable_table_admin/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Copyright 2025 Google LLC.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# TODO: Add the async client after owlbot changes.

from .client import BigtableTableAdminClient

__all__ = ("BigtableTableAdminClient",)
Copy link
Contributor

@daniel-sanche daniel-sanche May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the async client?

Loading
Loading