Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jackdingilian
Copy link
Contributor

@jackdingilian jackdingilian commented Jul 14, 2025

This updates the testproxy to match the MutateRows error handling change in googleapis/cloud-bigtable-clients-test@826dfa6

Additionally, there are new deadline_exceeded tests that require adjusting the errors within the test proxy. There is a race that can cause deadline exceeded to manifest as either cancelled or deadline_exceeded in the client. See the comments for rationale on handling this

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jackdingilian jackdingilian requested review from a team as code owners July 14, 2025 20:16
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jul 14, 2025
@jackdingilian jackdingilian force-pushed the update-conformance-tests branch 3 times, most recently from 1be8555 to 9b3fb6c Compare July 14, 2025 20:56
@bhshkh bhshkh assigned daniel-sanche and unassigned bhshkh Jul 15, 2025
@jackdingilian jackdingilian force-pushed the update-conformance-tests branch from 9b3fb6c to 43b1590 Compare July 15, 2025 14:22
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 15, 2025
@jackdingilian jackdingilian force-pushed the update-conformance-tests branch 4 times, most recently from d430a4d to 5466ee1 Compare July 15, 2025 18:28
@jackdingilian jackdingilian force-pushed the update-conformance-tests branch from 5466ee1 to 2c9cfcc Compare July 15, 2025 19:28
@daniel-sanche daniel-sanche changed the title Use latest conformance test version and exclude unsupported features chore(tests): Use latest conformance test version and exclude unsupported features Jul 15, 2025
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think system tests are failing due to a quota issue, but once those pass we can merge

@daniel-sanche daniel-sanche added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 15, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2025
@jackdingilian jackdingilian added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2025
@jackdingilian jackdingilian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2025
@jackdingilian jackdingilian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@jackdingilian jackdingilian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 17, 2025
@jackdingilian jackdingilian merged commit 3648d70 into googleapis:main Jul 18, 2025
29 of 30 checks passed
@jackdingilian jackdingilian deleted the update-conformance-tests branch July 18, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants