chore: rename MutationBatcher table argument to target #1169
+86
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkevinzheng
approved these changes
Aug 26, 2025
gkevinzheng
reviewed
Aug 26, 2025
UPGRADING.md
Outdated
| - `google.cloud.bigtable.data.BigtableDataClientAsync` | ||
| - Admin API: | ||
| - `google.cloud.bigtable.admin.BigtableInstanceAdminClient` | ||
| - `google.cloud.bigtable.admin.BigtableInstanceAdminClientAsync` |
There was a problem hiding this comment.
nit: The async clients are named BigtableInstanceAdminAsyncClient and BigtableTableAdminAsyncClient respectively.
There was a problem hiding this comment.
Oh I wish we caught that earlier so they had consistent naming. Fixed it here though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Authorized View support was added, we updated
tablearguments totarget, since views could be used in place of conventional table objects. But we couldn't make that rename to the MutationBatcher class, because it is publicly exposed and could be a breaking change.This PR makes the change for inclusion in the next major release,
v3.0.0This PR also starts an UPDATING.md migration guide to detail any breaking changes for the
v3.0.0update. We can iterate on its contents over timeFixes: #1128