Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

tests: remove int64 field test #177

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

georgiyekkert
Copy link
Contributor

the test potentially brings flakiness

@georgiyekkert georgiyekkert requested review from a team as code owners December 29, 2021 01:33
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Dec 29, 2021
Copy link

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, rather than removing a flaky system test, we work to un-flake it (e.g., via retries / backoff). Is there an issue open for the flakiness? Does it fail under CI, or just locally (I can see that the image file might not be present on a developer's system).

@georgiyekkert
Copy link
Contributor Author

Usually, rather than removing a flaky system test, we work to un-flake it (e.g., via retries / backoff). Is there an issue open for the flakiness? Does it fail under CI, or just locally (I can see that the image file might not be present on a developer's system).

There is a GCP limitation - we can't create more than 6 images per hour per GCP project. Integration tests use the same project across all languages so the usage might be pretty high.
We discussed it with @vchudnov-g and this test is safe to delete.

@tseaver
Copy link

tseaver commented Dec 30, 2021

@georgiyekkert To my knowledge, integration tests do not share projects across languages (because many APIs have rate limits / quotas which would trigger such issues). However, in a period of rapid development, there might be multiple PRs within a single language active, causing system tests to fail due to such limits.

That comment aside, the PR should be OK to go forward if the test is truly not needed.

@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2022
@parthea parthea merged commit cdb45d5 into googleapis:main Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants