Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 26, 2021

@tseaver tseaver requested review from plamut, parthea and dandhlee August 26, 2021 18:59
@tseaver tseaver requested a review from a team as a code owner August 26, 2021 18:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a reference to master in .github/workflows/python-publish.yml, but that probably refers to the gh-action-pypi-publish repo.

    steps:
        ...
      - name: Publish Source Distribution
        uses: pypa/gh-action-pypi-publish@master

However, I did find references to VERSION_WHITELIST in scripts/manylinux/build_on_centos.sh. I believe the inclusive language version of that should be VERSION_ALLOWLIST.

Since the purpose of master -> main migration is to address precisely these things, let's also address that in the same PR.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 30, 2021

@plamut 0f9207d renames that variable to PYTHON_VERSIONS, which is even more descriptive of its actual use: there is no "allow" going on in the script.

@tseaver tseaver requested a review from plamut August 30, 2021 18:51
@dandhlee
Copy link
Contributor

Confirmed no other occurrences of master, merging this to unblock #79.

@dandhlee dandhlee merged commit 869d053 into main Aug 30, 2021
@dandhlee dandhlee deleted the migrate-main-to-master branch August 30, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants