feat: Multi db test parametrization #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwhogg
approved these changes
May 9, 2023
|
The systems tests are failing because we don't have the Once the database created, populated with data, and indexes created, the tests should pass. |
Remove "database" argument from Query and AggregationQuery constructors. Use the "database" from the client instead. Once set in the client, the "database" will be used throughout and cannot be re-set. Parametrize the tests where-ever clients are used. Use the `system-tests-named-db` in the system test.
513e772 to
544dab7
Compare
|
This PR is now rebased against |
|
Systems test are now passing. |
|
I've updated these PRs and got the tests green. Seeking a go ahead for merging this. |
rwhogg
reviewed
Jun 14, 2023
|
Removed a review request from Aza due to team transfer, but still seeking approval from a Python person. |
m-strzelczyk
requested changes
Jun 20, 2023
parthea
approved these changes
Jun 20, 2023
m-strzelczyk
approved these changes
Jun 21, 2023
m-strzelczyk
pushed a commit
that referenced
this pull request
Jun 21, 2023
* feat: named database support (#398) * feat: Add named database support * test: Use named db in system tests * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Handle the case when client doesn't have database property * fix: add custom routing headers * Fixing tests for easier merge * fixing code coverage * addressing pr comments * feat: Multi db test parametrization (#436) * Feat: Parametrize the tests for multidb support Remove "database" argument from Query and AggregationQuery constructors. Use the "database" from the client instead. Once set in the client, the "database" will be used throughout and cannot be re-set. Parametrize the tests where-ever clients are used. Use the `system-tests-named-db` in the system test. * Add test case for when parent database name != child database name * Update owlbot, removing the named db parameter * Reverted test fixes * fixing tests * fix code coverage * pr suggestion * address pr comments --------- Co-authored-by: Vishwaraj Anand <[email protected]> --------- Co-authored-by: Bob "Wombat" Hogg <[email protected]> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Vishwaraj Anand <[email protected]> Co-authored-by: meredithslota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
This PR adds changes on top of #398, which was not yet merged to
main.The changes are:
Client, and the underlying queries and aggregation queries will retrieve thedatabaseid from theClient.database_idvaluesdatabase_idfieldFixes #<issue_number_goes_here> 🦕