fix: Using end_cursor instead of skipped_cursor in Iterator to fix rare bug. #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
end_cursorinstead ofskipped_cursorto fix #547. There are some rare edge cases whereskipped_cursorreturns an empty string with still more things to skip. Switching toend_cursorresolves this issue. Also does not reintroduce the bug that was fixed in #18, as in those cases,skipped_cursorandend_cursorare the same.Integration tests will be coming soon, maybe in a future PR, as making a dataset that consistently replicates this issue is still under investigation.