Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: migrate to main branch #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 25, 2021
Merged

chore: migrate to main branch #76

merged 4 commits into from
Aug 25, 2021

Conversation

dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Aug 24, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #75 🦕

@dandhlee dandhlee requested a review from parthea August 24, 2021 02:29
@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 02:29
@product-auto-label product-auto-label bot added the api: dns Issues related to the googleapis/python-dns API. label Aug 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
parthea
parthea reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observation, otherwise LGTM.

README.rst Outdated

.. |alpha| image:: https://img.shields.io/badge/support-alpha-orange.svg
:target: https://github.com/googleapis/google-cloud-python/blob/master/README.rst#alpha-support
:target: https://github.com/googleapis/google-cloud-python/blob/main/README.rst#alpha-support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with the new link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dandhlee dandhlee changed the title docs: migrate to main branch chore: migrate to main branch Aug 24, 2021
@dandhlee dandhlee requested a review from parthea August 24, 2021 21:36
@dandhlee
Copy link
Contributor Author

Please take a look again!

@parthea parthea merged commit bf4639a into main Aug 25, 2021
@parthea parthea deleted the to_main branch August 25, 2021 16:57
@parthea parthea mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: dns Issues related to the googleapis/python-dns API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to main branch
2 participants
@dandhlee @parthea