Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 16, 2023. It is now read-only.

chore: delete migrated samples #265

Merged
merged 2 commits into from
Jan 31, 2023
Merged

chore: delete migrated samples #265

merged 2 commits into from
Jan 31, 2023

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Jan 30, 2023

Delete samples migrated as part of this PR: GoogleCloudPlatform/python-docs-samples#8497

@Sita04 Sita04 requested a review from a team as a code owner January 30, 2023 19:36
@Sita04 Sita04 requested a review from parthea January 30, 2023 19:36
@snippet-bot
Copy link

snippet-bot bot commented Jan 30, 2023 •
edited
Loading

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: iam Issues related to the googleapis/python-iam API. samples Issues that are directly related to samples. labels Jan 30, 2023
@Sita04 Sita04 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. blunderbuss: assign Instruct blunderbuss to assign someone automerge Merge the pull request once unit tests and other checks pass. and removed api: iam Issues related to the googleapis/python-iam API. samples Issues that are directly related to samples. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 30, 2023
@Sita04 Sita04 removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 31, 2023
@product-auto-label product-auto-label bot added api: iam Issues related to the googleapis/python-iam API. samples Issues that are directly related to samples. labels Jan 31, 2023
@dandhlee dandhlee added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 31, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 31, 2023
dandhlee
dandhlee approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you add a README on samples/snippet/ directory to let folks know that files have moved to python-docs-samples repo?

@dandhlee dandhlee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 31, 2023
@Sita04 Sita04 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 31, 2023
@Sita04 Sita04 merged commit c32c2c7 into main Jan 31, 2023
@Sita04 Sita04 deleted the delete-migrated-samples branch January 31, 2023 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@dandhlee dandhlee dandhlee approved these changes

@parthea parthea Awaiting requested review from parthea parthea was automatically assigned from googleapis/python-samples-reviewers

Assignees

@parthea parthea

Labels
api: iam Issues related to the googleapis/python-iam API. blunderbuss: assign Instruct blunderbuss to assign someone samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sita04 @kweinmeister @dandhlee @parthea