test: reduced time filter length in system tests #161
Conversation
9ec7773 to
6e16495
Compare
| :rtype: list | ||
| :returns: List of all entries consumed. | ||
| """ | ||
| return list(logger.list_entries()) | ||
| return list(logger.list_entries(filter_=_time_filter)) |
There was a problem hiding this comment.
nit: this looks really ugly. Is it a python convention to name variables with underscores as both the prefix and suffix? At least, maybe worth having a space before and after "=" for clarity.
There was a problem hiding this comment.
filter_ is used because fitler is a keyword (I think it's part of the code generation process). Prefix underscores are more standard for internal variables.
Unfortunately we can't add spaces because it wouldn't be accepted by the linter. I think since this is all test code it should be fine though
|
Anything labeled as a |
Good point. Switched to |
CI system tests have been failing for a week now. It looks like a rogue service has been flooding the test project with logs, which made our tests timeout
We fixed the problem on the project side, but I'm also introducing a change here to only query the last 10 minutes of logs. This should avoid similar problems from breaking our tests in the future