Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: structured log handler formatting issues #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daniel-sanche merged 9 commits into from
Jun 10, 2021
Merged

fix: structured log handler formatting issues #319

daniel-sanche merged 9 commits into from
Jun 10, 2021

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Jun 8, 2021 •
edited
Loading

This PR fixes a number of formatting edge cases around the StructuredLogHandler:

Fixes #314, #318, #313 🦕

@daniel-sanche daniel-sanche requested review from a team as code owners June 8, 2021 00:07
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Jun 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 9, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT] fix: structured log handler formatting issues fix: structured log handler formatting issues Jun 10, 2021
@daniel-sanche daniel-sanche merged commit db9da37 into master Jun 10, 2021
@daniel-sanche daniel-sanche deleted the fix-structured-log-format branch June 10, 2021 21:13
This was referenced Jun 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simonz130 simonz130 simonz130 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@daniel-sanche daniel-sanche

Labels

api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: support custom log formatters attached to handlers

3 participants

@daniel-sanche @simonz130 @yoshi-kokoro