Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

gkevinzheng
Copy link
Contributor

Breaking PR for go/python-logging-background-thread.

PR for the rest of the changes involving closing and flushing handlers be included in a separate PR, as will a PR for updating UPGRADING.md.

@gkevinzheng gkevinzheng requested review from a team as code owners June 24, 2024 19:42
@gkevinzheng gkevinzheng requested review from cindy-peng and removed request for a team June 24, 2024 19:42
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jun 24, 2024
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Jun 24, 2024
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2024
@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 25, 2024
@gkevinzheng gkevinzheng merged commit f92c9b8 into experimental-v4 Jun 25, 2024
@gkevinzheng gkevinzheng deleted the gae-structured-log branch June 25, 2024 14:41
gkevinzheng added a commit that referenced this pull request Jul 29, 2024
…Handler (#908)

* feat!: Use StructuredLogHandler on App Engine instead of
CloudLoggingHandler

* linting
gkevinzheng added a commit that referenced this pull request Jul 30, 2024
* fix!: Use StructuredLogHandler for Cloud Run Job

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Merge main into experimental-v4 (#906)

* fix: Added missing import into logger.py (#896)

* test: Fixed unsupported resource type in system test (#904)

* fix: Added type hints to CloudLoggingHandler constructor (#903)

* fix: Added type hints to CloudLoggingHandler constructor

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Removed Client typing due to circular imports

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat!: Use StructuredLogHandler on App Engine instead of CloudLoggingHandler (#908)

* feat!: Use StructuredLogHandler on App Engine instead of
CloudLoggingHandler

* linting

* fix!: Use StructuredLogHandler for Cloud Run Job

* Removed print statement

* Resolved all merge conflicts

* linting

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants