Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Fixed type hinting issue with specifying Transport class #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix: Fixed type hinting issue with specifying Transport class #930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1053370
Fixed type hinting issue with specifying Transport class
gkevinzheng Aug 7, 2024
fdc8fa4
Switching to typing.Type for compatibility with older Python versions
gkevinzheng Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/logging_v2/handlers/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import json
import logging

from typing import Optional, IO
from typing import Optional, IO, Type

from google.cloud.logging_v2.handlers.transports import (
BackgroundThreadTransport,
Expand Down Expand Up @@ -157,7 +157,7 @@ def __init__(
client,
*,
name: str = DEFAULT_LOGGER_NAME,
transport: Transport = BackgroundThreadTransport,
transport: Type[Transport] = BackgroundThreadTransport,
resource: Resource = None,
labels: Optional[dict] = None,
stream: Optional[IO] = None,
Expand Down